Quick fixes & tests
This commit is contained in:
@@ -4,14 +4,13 @@ from redmine_reporter.client import fetch_issues_with_spent_time
|
||||
|
||||
|
||||
@mock.patch("redmine_reporter.client.Redmine")
|
||||
def test_fetch_issues_with_spent_time(mock_redmine_class):
|
||||
# Подготовка моков
|
||||
def test_fetch_aggregates_hours_per_issue(mock_redmine_class):
|
||||
"""Два time entry на одну задачу -- часы суммируются."""
|
||||
mock_redmine = mock_redmine_class.return_value
|
||||
mock_user = mock.MagicMock()
|
||||
mock_user.id = 123
|
||||
mock_redmine.user.get.return_value = mock_user
|
||||
|
||||
# Два time entry на одну задачу
|
||||
mock_entry1 = mock.MagicMock()
|
||||
mock_entry1.issue.id = 101
|
||||
mock_entry1.hours = 2.0
|
||||
@@ -20,7 +19,6 @@ def test_fetch_issues_with_spent_time(mock_redmine_class):
|
||||
mock_entry2.hours = 1.5
|
||||
mock_redmine.time_entry.filter.return_value = [mock_entry1, mock_entry2]
|
||||
|
||||
# Мок задачи
|
||||
mock_issue = mock.MagicMock()
|
||||
mock_issue.id = 101
|
||||
mock_issue.project = "Проект X"
|
||||
@@ -34,3 +32,71 @@ def test_fetch_issues_with_spent_time(mock_redmine_class):
|
||||
assert len(result) == 1
|
||||
issue, total_hours = result[0]
|
||||
assert total_hours == 3.5
|
||||
|
||||
|
||||
@mock.patch("redmine_reporter.client.Redmine")
|
||||
def test_fetch_returns_none_when_no_entries(mock_redmine_class):
|
||||
"""Нет time entries -- возвращается None."""
|
||||
mock_redmine = mock_redmine_class.return_value
|
||||
mock_user = mock.MagicMock()
|
||||
mock_user.id = 1
|
||||
mock_redmine.user.get.return_value = mock_user
|
||||
mock_redmine.time_entry.filter.return_value = []
|
||||
|
||||
result = fetch_issues_with_spent_time("2026-01-01", "2026-01-31")
|
||||
assert result is None
|
||||
|
||||
|
||||
@mock.patch("redmine_reporter.client.Redmine")
|
||||
def test_fetch_skips_entries_without_issue(mock_redmine_class):
|
||||
"""Time entry без привязки к задаче игнорируется."""
|
||||
mock_redmine = mock_redmine_class.return_value
|
||||
mock_user = mock.MagicMock()
|
||||
mock_user.id = 1
|
||||
mock_redmine.user.get.return_value = mock_user
|
||||
|
||||
# entry без issue атрибута
|
||||
entry_no_issue = mock.MagicMock(spec=["hours"]) # нет .issue
|
||||
entry_no_issue.hours = 1.0
|
||||
|
||||
mock_redmine.time_entry.filter.return_value = [entry_no_issue]
|
||||
|
||||
result = fetch_issues_with_spent_time("2026-01-01", "2026-01-31")
|
||||
assert result is None
|
||||
|
||||
|
||||
@mock.patch("redmine_reporter.client.Redmine")
|
||||
def test_fetch_multiple_issues(mock_redmine_class):
|
||||
"""Несколько задач -- каждая с правильным суммарным временем."""
|
||||
mock_redmine = mock_redmine_class.return_value
|
||||
mock_user = mock.MagicMock()
|
||||
mock_user.id = 1
|
||||
mock_redmine.user.get.return_value = mock_user
|
||||
|
||||
def make_entry(issue_id, hours):
|
||||
e = mock.MagicMock()
|
||||
e.issue.id = issue_id
|
||||
e.hours = hours
|
||||
return e
|
||||
|
||||
mock_redmine.time_entry.filter.return_value = [
|
||||
make_entry(1, 1.0),
|
||||
make_entry(2, 2.0),
|
||||
make_entry(1, 0.5),
|
||||
]
|
||||
|
||||
mock_issue1 = mock.MagicMock()
|
||||
mock_issue1.id = 1
|
||||
mock_issue1.project = "P"
|
||||
mock_issue2 = mock.MagicMock()
|
||||
mock_issue2.id = 2
|
||||
mock_issue2.project = "P"
|
||||
mock_redmine.issue.filter.return_value = [mock_issue1, mock_issue2]
|
||||
|
||||
result = fetch_issues_with_spent_time("2026-01-01", "2026-01-31")
|
||||
assert result is not None
|
||||
assert len(result) == 2
|
||||
|
||||
hours_by_id = {issue.id: hours for issue, hours in result}
|
||||
assert hours_by_id[1] == 1.5
|
||||
assert hours_by_id[2] == 2.0
|
||||
|
||||
Reference in New Issue
Block a user