Fix .env override priority and password whitespace stripping
Change load_dotenv() to load_dotenv(override=False) so real environment variables always take priority over stale .env files. This prevents a hardcoded or outdated REDMINE_API_KEY in .env from silently overriding a fresh token exported in the shell (#15). Add .strip() to get_redmine_password() for consistency with all other config getters — trailing whitespace in .env no longer causes silent auth failures (#35). Closes #15, closes #35
This commit is contained in:
@@ -99,3 +99,27 @@ def test_get_redmine_verify_true_values(value):
|
||||
@mock.patch.dict(os.environ, {"REDMINE_VERIFY": "/tmp/redmine-ca.pem"}, clear=True)
|
||||
def test_get_redmine_verify_custom_path():
|
||||
assert Config.get_redmine_verify() == "/tmp/redmine-ca.pem"
|
||||
|
||||
|
||||
# -- #15: .env не должен переопределять переменные окружения --
|
||||
|
||||
|
||||
@mock.patch("dotenv.load_dotenv")
|
||||
def test_env_var_takes_priority_over_dotenv(mock_load):
|
||||
"""load_dotenv вызывается с override=False — env vars не перебиваются .env."""
|
||||
import importlib
|
||||
|
||||
from redmine_reporter import config as cfg_mod
|
||||
|
||||
importlib.reload(cfg_mod)
|
||||
|
||||
mock_load.assert_called_once_with(override=False)
|
||||
|
||||
|
||||
# -- #35: get_redmine_password должен делать .strip() --
|
||||
|
||||
|
||||
@mock.patch.dict(os.environ, {"REDMINE_PASSWORD": " secret123 "}, clear=True)
|
||||
def test_get_redmine_password_strips_whitespace():
|
||||
"""Пароль обрезается от whitespace, как и все остальные геттеры."""
|
||||
assert Config.get_redmine_password() == "secret123"
|
||||
|
||||
Reference in New Issue
Block a user