Tighten configuration and export handling

tests/test_config.py

@@ -1,81 +1,101 @@
-import pytest
+import os
 from unittest import mock
-from redmine_reporter.config import Config
 
-# Config читает os.getenv() в момент определения класса (class-level атрибуты),
-# поэтому mock.patch.dict(os.environ) не помогает -- класс уже загружен.
-# Правильный способ -- патчить атрибуты самого класса.
+import pytest
+
+from redmine_reporter.config import DEFAULT_REDMINE_VERIFY, Config
 
 
-@mock.patch.multiple(
-    Config,
-    REDMINE_URL="https://red.eltex.loc",
-    REDMINE_API_KEY=None,
-    REDMINE_USER="test",
-    REDMINE_PASSWORD="secret",
+@mock.patch.dict(
+    os.environ,
+    {
+        "REDMINE_URL": "https://red.eltex.loc/",
+        "REDMINE_USER": "test",
+        "REDMINE_PASSWORD": "secret",
+    },
+    clear=True,
 )
 def test_config_valid_with_password_fallback():
     Config.validate()  # не должно быть исключения
 
 
-@mock.patch.multiple(
-    Config,
-    REDMINE_URL="https://red.eltex.loc",
-    REDMINE_API_KEY="token",
-    REDMINE_USER=None,
-    REDMINE_PASSWORD=None,
+@mock.patch.dict(
+    os.environ,
+    {
+        "REDMINE_URL": "https://red.eltex.loc/",
+        "REDMINE_API_KEY": "token",
+    },
+    clear=True,
 )
 def test_config_valid_with_api_key():
     Config.validate()  # не должно быть исключения
 
 
-@mock.patch.multiple(
-    Config,
-    REDMINE_URL="",
-    REDMINE_API_KEY=None,
-    REDMINE_USER=None,
-    REDMINE_PASSWORD=None,
-)
+@mock.patch.dict(os.environ, {}, clear=True)
 def test_config_missing_url():
     with pytest.raises(ValueError, match="REDMINE_URL"):
         Config.validate()
 
 
-@mock.patch.multiple(
-    Config,
-    REDMINE_URL="https://red.eltex.loc",
-    REDMINE_API_KEY=None,
-    REDMINE_USER=None,
-    REDMINE_PASSWORD=None,
-)
+@mock.patch.dict(os.environ, {"REDMINE_URL": "https://red.eltex.loc/"}, clear=True)
 def test_config_missing_auth():
     with pytest.raises(ValueError, match="REDMINE_API_KEY"):
         Config.validate()
 
 
-@mock.patch.multiple(Config, REDMINE_AUTHOR="Иванов И.И.")
+@mock.patch.dict(os.environ, {"REDMINE_URL": " https://red.eltex.loc/ "}, clear=True)
+def test_get_redmine_url_strips_spaces_and_trailing_slash():
+    assert Config.get_redmine_url() == "https://red.eltex.loc"
+
+
+@mock.patch.dict(os.environ, {"REDMINE_AUTHOR": " Иванов И.И. "}, clear=True)
 def test_get_author():
     assert Config.get_author("") == "Иванов И.И."
     assert Config.get_author("Петров П.П.") == "Петров П.П."
 
 
-@mock.patch.multiple(Config, REDMINE_AUTHOR=None)
+@mock.patch.dict(os.environ, {}, clear=True)
 def test_get_author_fallback():
     """Если ни CLI, ни .env не задали автора -- возвращается пустая строка."""
     assert Config.get_author("") == ""
 
 
-@mock.patch.multiple(
-    Config,
-    DEFAULT_FROM_DATE="2026-01-01",
-    DEFAULT_TO_DATE="2026-01-31",
+@mock.patch.dict(
+    os.environ,
+    {
+        "DEFAULT_FROM_DATE": "2026-01-01",
+        "DEFAULT_TO_DATE": "2026-01-31",
+    },
+    clear=True,
 )
 def test_get_default_date_range_from_env():
     assert Config.get_default_date_range() == "2026-01-01--2026-01-31"
 
 
-@mock.patch.multiple(Config, DEFAULT_FROM_DATE=None, DEFAULT_TO_DATE=None)
+@mock.patch.dict(os.environ, {}, clear=True)
 def test_get_default_date_range_fallback():
     """Если даты не заданы -- используется хардкод-заглушка."""
     result = Config.get_default_date_range()
     assert "--" in result  # формат YYYY-MM-DD--YYYY-MM-DD
+
+
+@mock.patch.dict(os.environ, {}, clear=True)
+def test_get_redmine_verify_default():
+    assert Config.get_redmine_verify() == DEFAULT_REDMINE_VERIFY
+
+
+@pytest.mark.parametrize("value", ["0", "false", "False", "no", "off"])
+def test_get_redmine_verify_false_values(value):
+    with mock.patch.dict(os.environ, {"REDMINE_VERIFY": value}, clear=True):
+        assert Config.get_redmine_verify() is False
+
+
+@pytest.mark.parametrize("value", ["1", "true", "True", "yes", "on"])
+def test_get_redmine_verify_true_values(value):
+    with mock.patch.dict(os.environ, {"REDMINE_VERIFY": value}, clear=True):
+        assert Config.get_redmine_verify() is True
+
+
+@mock.patch.dict(os.environ, {"REDMINE_VERIFY": "/tmp/redmine-ca.pem"}, clear=True)
+def test_get_redmine_verify_custom_path():
+    assert Config.get_redmine_verify() == "/tmp/redmine-ca.pem"